Repository navigation
Implement the measure boxes on the operations - #54
Merged
dannycoulombe merged 2 commits intoNov 13, 2026
Merged
dannycoulombe merged 2 commits into
dannycoulombe merged 2 commits into
Conversation
Collaborator
|
Interesting. I like the idea. Will test it out. |
Jairolaya12x
marked this pull request as ready for review
November 13, 2026 20:50
Contributor
Author
|
For some reason I can't upload the demo on github 😢 https://streamable.com/jdiq4e but here an example of the code working |
Collaborator
Oh nice... that look very slick! I am finilizing with another PR and will checkout this one after. |
Collaborator
|
Beautiful. The formulas still work. :-) I made two minor changes:
Otherwise this feature is great. It makes distances much clearer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typed dimensions are now shown in floating boxes placed on the edge they affect (similar to Fusion 360), instead of only in the status-bar field.
The
5m,50mmsyntax still works.2 cmnow works like2cm. While a dimension is being typed, Space and letter keys no longer trigger tool shortcuts. With an empty dimension, Space still switches to Select.The status-bar field is hidden while floating boxes are enabled. It is still used when the new View → Floating Dimension Input option is turned off (persisted, on by default), and for Tape Measure and Protractor.
Implementation notes
crates/benchup-app/src/dimension_overlay.rs. The boxes are display-only: typed text already flows intolength_inputwithout focus, so a second focusable text field would duplicate input.width,heightbuffer format, so formulas, the status-bar field and commit logic are unchanged.app.width,app.height,app.push_pull_total,sidebar.floating_dimension_input; updated rectangle hint text.Tests
Added coverage for Tab/Shift+Tab field switching and selection, single-side rectangle input, invalid sides, input length limit, arc height (sagitta), Push/Pull total, spaces inside dimensions, the hidden status-bar field, and persistence
of the new option.